Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing commas in editorconfig #6768

Merged
merged 6 commits into from Dec 13, 2023
Merged

Trailing commas in editorconfig #6768

merged 6 commits into from Dec 13, 2023

Conversation

AntonC9018
Copy link
Contributor

  • Enforce trailing commas in lists;
  • Add trailing commas in some of the projects.

Now, I think naming conventions can't be properly configured in a generic way.
Rider would simply ignore them.

There are Rider settings, but they are:

  • Rider-specific,
  • per-solution,
  • are currently ignored in the repo.

So I'll refrain from further action on this for now.

Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 73 lines in your changes are missing coverage. Please review.

Comparison is base (3ed4025) 63.92% compared to head (6831d9e) 63.92%.
Report is 1 commits behind head on main.

Files Patch % Lines
...Types/Resolvers/DirectiveClassMiddlewareFactory.cs 0.00% 5 Missing ⚠️
.../Types/Extensions/DirectiveCollectionExtensions.cs 0.00% 5 Missing ⚠️
...pes.Mutations/MutationConventionTypeInterceptor.cs 0.00% 4 Missing ⚠️
...src/Types.Mutations/Errors/ErrorFactoryCompiler.cs 0.00% 3 Missing ⚠️
src/HotChocolate/Core/src/Abstractions/Path.cs 0.00% 2 Missing ⚠️
src/HotChocolate/Core/src/Execution/ErrorHelper.cs 50.00% 2 Missing ⚠️
.../Execution/Pipeline/OperationResolverMiddleware.cs 60.00% 2 Missing ⚠️
...xecution/Pipeline/WritePersistedQueryMiddleware.cs 0.00% 2 Missing ⚠️
...colate/Core/src/Execution/Processing/PathHelper.cs 50.00% 2 Missing ⚠️
.../Core/src/Types/Types/Extensions/TypeExtensions.cs 0.00% 2 Missing ⚠️
... and 40 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6768   +/-   ##
=======================================
  Coverage   63.92%   63.92%           
=======================================
  Files        2324     2324           
  Lines      114629   114629           
=======================================
+ Hits        73275    73277    +2     
+ Misses      41354    41352    -2     
Flag Coverage Δ
unittests 63.92% <56.02%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Qodana for .NET

376 new problems were found

Inspection name Severity Problems
Use preferred style for trailing comma before new line in multiline lists 🔴 Failure 330
Unused parameter (private accessibility) 🔶 Warning 23
Type member is never used (private accessibility) 🔶 Warning 20
Redundant using directive 🔶 Warning 3

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@michaelstaib michaelstaib merged commit 4ed282b into main Dec 13, 2023
70 of 99 checks passed
@michaelstaib michaelstaib deleted the anton/editorconfig branch December 13, 2023 17:06
@PascalSenn PascalSenn mentioned this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants