Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation of input fields / arguments #6786

Merged
merged 7 commits into from Dec 24, 2023
Merged

Conversation

tobias-tengler
Copy link
Collaborator

@tobias-tengler tobias-tengler commented Dec 19, 2023

This PR allows non-null input fields / arguments to be deprecated as long as they have specified a default value, according to the spec:
image

Further this PR changes the IntrospectionClient to conditionally include deprecated input fields / arguments and select whether they are deprecated and their deprecationReason.

Fixes #6785

@github-actions github-actions bot added 🌶️ hot chocolate 📚 documentation This issue is about working on our documentation. labels Dec 19, 2023
@tobias-tengler tobias-tengler added the 👓 ready-for-review The PR is ready for review. label Dec 19, 2023
Copy link

github-actions bot commented Dec 19, 2023

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cbcb4b5) 70.92% compared to head (a5fcde5) 70.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6786      +/-   ##
==========================================
- Coverage   70.92%   70.91%   -0.01%     
==========================================
  Files        2520     2520              
  Lines      126567   126567              
==========================================
- Hits        89763    89755       -8     
- Misses      36804    36812       +8     
Flag Coverage Δ
unittests 70.91% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobias-tengler
Copy link
Collaborator Author

All the tests are passing on my machine, I don't think the test failures in CI are related to my changes.

Copy link

sonarcloud bot commented Dec 24, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@michaelstaib michaelstaib merged commit f586c51 into main Dec 24, 2023
91 of 99 checks passed
@michaelstaib michaelstaib deleted the tte/input-deprecation branch December 24, 2023 09:02
@PascalSenn PascalSenn mentioned this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation This issue is about working on our documentation. 🌶️ hot chocolate 👓 ready-for-review The PR is ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downloaded schema misses deprecated directive of field argument
2 participants