Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spellcheck job #6811

Merged
merged 3 commits into from Jan 10, 2024
Merged

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Jan 10, 2024

Summary of the changes (Less than 80 chars)

  • Update Node.js for spellcheck job.
  • Fix spelling errors.

@github-actions github-actions bot added 📚 documentation This issue is about working on our documentation. 🧰 maintenance labels Jan 10, 2024
Copy link

sonarcloud bot commented Jan 10, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f586c51) 70.98% compared to head (5304ebb) 70.93%.
Report is 2 commits behind head on main.

❗ Current head 5304ebb differs from pull request most recent head 47dab58. Consider uploading reports for the commit 47dab58 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6811      +/-   ##
==========================================
- Coverage   70.98%   70.93%   -0.05%     
==========================================
  Files        2534     2520      -14     
  Lines      127227   126591     -636     
==========================================
- Hits        90306    89802     -504     
+ Misses      36921    36789     -132     
Flag Coverage Δ
unittests 70.93% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tobias-tengler tobias-tengler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to run with the correct version in CI, but that's probably because the. change is coming from a fork?

@glen-84
Copy link
Collaborator Author

glen-84 commented Jan 10, 2024

Doesn't seem to run with the correct version in CI, but that's probably because the. change is coming from a fork?

Ya, probably.

@michaelstaib michaelstaib merged commit 50bf710 into ChilliCream:main Jan 10, 2024
4 of 5 checks passed
@glen-84 glen-84 deleted the fix-spellcheck-job branch January 11, 2024 07:15
@PascalSenn PascalSenn mentioned this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation This issue is about working on our documentation. 🧰 maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants