Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to C# Collection Expressions. #6845

Merged
merged 4 commits into from Jan 23, 2024
Merged

Switch to C# Collection Expressions. #6845

merged 4 commits into from Jan 23, 2024

Conversation

michaelstaib
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 90 lines in your changes are missing coverage. Please review.

Comparison is base (8bf1558) 70.16% compared to head (318ca22) 70.28%.
Report is 1 commits behind head on main.

❗ Current head 318ca22 differs from pull request most recent head 5d1781b. Consider uploading reports for the commit 5d1781b to get more accurate results

Files Patch % Lines
...rc/Types/Types/Introspection/IntrospectionTypes.cs 0.00% 12 Missing ⚠️
...late/Core/src/Types/Types/Directives/Directives.cs 0.00% 8 Missing ⚠️
...es/Descriptors/Definitions/ObjectTypeDefinition.cs 50.00% 6 Missing ⚠️
...Descriptors/Definitions/InterfaceTypeDefinition.cs 20.00% 4 Missing ⚠️
...s/Descriptors/Definitions/ObjectFieldDefinition.cs 66.66% 4 Missing ⚠️
...nterceptors/MiddlewareValidationTypeInterceptor.cs 33.33% 4 Missing ⚠️
...on/src/CommandLine/Commands/SubgraphPackCommand.cs 0.00% 4 Missing ⚠️
...e/src/Abstractions/Execution/QueryResultBuilder.cs 25.00% 3 Missing ⚠️
...escriptors/Definitions/InterfaceFieldDefinition.cs 0.00% 3 Missing ⚠️
...late/Core/src/Types/Utilities/ListTypeConverter.cs 0.00% 3 Missing ⚠️
... and 29 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6845      +/-   ##
==========================================
+ Coverage   70.16%   70.28%   +0.12%     
==========================================
  Files        2485     2499      +14     
  Lines      125521   126157     +636     
==========================================
+ Hits        88067    88665     +598     
- Misses      37454    37492      +38     
Flag Coverage Δ
unittests 70.28% <80.81%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 23, 2024

Qodana for .NET

11 new problems were found

Inspection name Severity Problems
Redundant explicit type in array creation 🔶 Warning 7
Member hides static member from outer class 🔶 Warning 2
Redundant type declaration body 🔶 Warning 2

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@michaelstaib michaelstaib merged commit 01daf1e into main Jan 23, 2024
3 checks passed
@michaelstaib michaelstaib deleted the mst/collection-init branch January 23, 2024 09:46
@PascalSenn PascalSenn mentioned this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant