Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize OptionTypeConverter #6883

Merged
merged 4 commits into from Feb 13, 2024
Merged

Optimize OptionTypeConverter #6883

merged 4 commits into from Feb 13, 2024

Conversation

cmeeren
Copy link
Contributor

@cmeeren cmeeren commented Feb 12, 2024

The original version used slow reflection with no caching.

This version uses optimized reflection (both caching and pre-computed readers/constructors).

Briefly verified to work manually. Assuming there are unit tests already in place for this code.

@CLAassistant
Copy link

CLAassistant commented Feb 12, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d44f09) 70.45% compared to head (7d92c76) 70.37%.

❗ Current head 7d92c76 differs from pull request most recent head fafa5ac. Consider uploading reports for the commit fafa5ac to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6883      +/-   ##
==========================================
- Coverage   70.45%   70.37%   -0.08%     
==========================================
  Files        2570     2551      -19     
  Lines      127710   126984     -726     
==========================================
- Hits        89974    89363     -611     
+ Misses      37736    37621     -115     
Flag Coverage Δ
unittests 70.37% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit c5a043e into ChilliCream:main Feb 13, 2024
2 of 3 checks passed
@cmeeren cmeeren deleted the patch-1 branch February 13, 2024 07:14
@PascalSenn PascalSenn mentioned this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants