Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type System Spring Cleaning #6885

Merged
merged 3 commits into from Feb 12, 2024
Merged

Type System Spring Cleaning #6885

merged 3 commits into from Feb 12, 2024

Conversation

michaelstaib
Copy link
Member

No description provided.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (8c26d3b) 73.16% compared to head (9f3e5b0) 70.51%.

❗ Current head 9f3e5b0 differs from pull request most recent head 173dc86. Consider uploading reports for the commit 173dc86 to get more accurate results

Files Patch % Lines
...tChocolate/Core/src/Types/Utilities/ErrorHelper.cs 0.00% 3 Missing ⚠️
...es/Descriptors/Definitions/TypeDefinitionBase~1.cs 33.33% 2 Missing ⚠️
...ocolate/Core/src/Types/Internal/FieldInitHelper.cs 0.00% 1 Missing ⚠️
...c/HotChocolate/Core/src/Types/Types/ObjectField.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6885      +/-   ##
==========================================
- Coverage   73.16%   70.51%   -2.65%     
==========================================
  Files        2570     2570              
  Lines      127876   127876              
==========================================
- Hits        93561    90176    -3385     
- Misses      34315    37700    +3385     
Flag Coverage Δ
unittests 70.51% <65.00%> (-2.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit 4cd121e into main Feb 12, 2024
8 of 10 checks passed
@michaelstaib michaelstaib deleted the mst/type-system-spring-clean branch February 12, 2024 21:48
@PascalSenn PascalSenn mentioned this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant