Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced internal Activator with ActivatorUtilities. #6895

Merged
merged 5 commits into from Feb 14, 2024

Conversation

michaelstaib
Copy link
Member

@michaelstaib michaelstaib commented Feb 13, 2024

Remove self backed activators and move to ActivatorUtilities included with Microsofts DependencyInjection abstractions package.

@michaelstaib michaelstaib changed the title Replaced internal activator with ActivatorUtilities. [aot] Replaced internal activator with ActivatorUtilities. Feb 13, 2024
@michaelstaib michaelstaib changed the title [aot] Replaced internal activator with ActivatorUtilities. [AOT] Replaced internal activator with ActivatorUtilities. Feb 13, 2024
@michaelstaib michaelstaib changed the title [AOT] Replaced internal activator with ActivatorUtilities. Replaced internal activator with ActivatorUtilities. Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 43 lines in your changes are missing coverage. Please review.

Comparison is base (3297b2d) 73.28% compared to head (24ad814) 70.68%.
Report is 1 commits behind head on main.

❗ Current head 24ad814 differs from pull request most recent head f7ab6e4. Consider uploading reports for the commit f7ab6e4 to get more accurate results

Files Patch % Lines
...hemaRequestExecutorBuilderExtensions.Convention.cs 0.00% 12 Missing ⚠️
.../Data/Projections/Convention/ProjectionProvider.cs 68.75% 10 Missing ⚠️
.../Core/src/Execution/Processing/DefaultActivator.cs 40.00% 6 Missing ⚠️
...late/Data/src/Data/Sorting/Visitor/SortProvider.cs 73.91% 6 Missing ⚠️
...te/Data/src/Data/Filters/Visitor/FilterProvider.cs 85.00% 3 Missing ⚠️
...late/Core/src/Types/Configuration/TypeRegistrar.cs 89.47% 2 Missing ⚠️
...etCoreServiceCollectionExtensions.Subscriptions.cs 0.00% 1 Missing ⚠️
.../Extensions/SchemaBuilderExtensions.Conventions.cs 92.30% 1 Missing ⚠️
...ata/Projections/Convention/ProjectionConvention.cs 66.66% 1 Missing ⚠️
...Data/src/Data/Sorting/Convention/SortConvention.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6895      +/-   ##
==========================================
- Coverage   73.28%   70.68%   -2.61%     
==========================================
  Files        2584     2584              
  Lines      128343   128343              
==========================================
- Hits        94062    90713    -3349     
- Misses      34281    37630    +3349     
Flag Coverage Δ
unittests 70.68% <76.75%> (-2.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 13, 2024

Qodana for .NET

5 new problems were found

Inspection name Severity Problems
Namespace does not correspond to file location 🔶 Warning 2
Private field can be converted into local variable 🔶 Warning 2
Redundant using directive 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@michaelstaib michaelstaib changed the title Replaced internal activator with ActivatorUtilities. Replaced internal Activator with ActivatorUtilities. Feb 14, 2024
@michaelstaib michaelstaib merged commit 3592a19 into main Feb 14, 2024
11 of 12 checks passed
@michaelstaib michaelstaib deleted the mst/aot-factories branch February 14, 2024 01:28
@PascalSenn PascalSenn mentioned this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant