Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the latter GetAttendeeAsync in SessionAttendeeCheckIn be GetSessionAsync instead? #29

Closed
gojanpaolo opened this issue Jan 7, 2021 · 2 comments · Fixed by #36
Closed

Comments

@gojanpaolo
Copy link
Contributor

gojanpaolo commented Jan 7, 2021

The class SessionAttendeeCheckIn currently have two definitions of GetAttendeeAsync

public Task<Attendee> GetAttendeeAsync(
AttendeeByIdDataLoader attendeeById,
CancellationToken cancellationToken) =>
attendeeById.LoadAsync(AttendeeId, cancellationToken);
public Task<Session> GetAttendeeAsync(
SessionByIdDataLoader sessionById,
CancellationToken cancellationToken) =>
sessionById.LoadAsync(AttendeeId, cancellationToken);

But it seems to me that the latter should be GetSessionAsync instead. Or am I missing something?

That part is specifically covered in 7-subscriptions.
... # 2 in https://github.com/ChilliCream/graphql-workshop/blob/master/docs/7-subscriptions.md#add-onattendeecheckedin-subscription

I'll be happy to create a PR if it needs correction

Btw, thank you for creating this workshop. I'm learning graphql and I'm having a great learning experience so far.

@michaelstaib
Copy link
Member

Yeas that is correct .... do you want to do a pull-request for this?

@gojanpaolo
Copy link
Contributor Author

@michaelstaib sure 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants