Fixed issues with the variable deserialization. #2326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rstaib
reviewed
Sep 16, 2020
src/HotChocolate/Language/src/Language.Utf8/Utf8GraphQLRequestParser.Utilities.cs
Show resolved
Hide resolved
src/HotChocolate/Language/src/Language.Utf8/Utf8GraphQLRequestParser.Utilities.cs
Show resolved
Hide resolved
src/HotChocolate/Language/src/Language.Utf8/Utf8GraphQLRequestParser.Values.cs
Show resolved
Hide resolved
src/HotChocolate/Language/test/Language.Tests/Parser/Utf8GraphQLRequestParserTests.cs
Show resolved
Hide resolved
src/HotChocolate/Language/test/Language.Tests/Parser/Utf8JsonParserTests.cs
Outdated
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a while, we had some issues with deserializing variables. The main issue was that the variables were fully deserialized in the middleware before we actually knew what types they could be. We now use our GraphQL syntax tree deserialize the variables into which now preserves the context of the values and does not force the parser to decide on a specific runtime type.
We still should have another look at this in version 12 and see if we can make the whole parser/request parser more efficient by reworking the syntax tree to handle value memory differently.
Fixes #1978