Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reworked Filter Naming Conventions #2618

Merged
merged 10 commits into from Nov 21, 2020
Merged

Reworked Filter Naming Conventions #2618

merged 10 commits into from Nov 21, 2020

Conversation

PascalSenn
Copy link
Member

  • Cleaner names of filter types
  • Align names of spatial filter types
  • UseFiltering() uses convention type lookup
  • FilterExtensions can override defaults

michaelstaib
michaelstaib previously approved these changes Nov 21, 2020
View reviewed changes
@michaelstaib michaelstaib changed the title feat: filtering naming Reworked Filter Naming Conventions Nov 21, 2020
@michaelstaib michaelstaib added this to backlog in Backlog via automation Nov 21, 2020
@michaelstaib michaelstaib added 🌶 hot chocolate 🎨 refactoring This issue is about doing refactoring work, like cleaning up the code making existing code better. labels Nov 21, 2020
@michaelstaib michaelstaib self-requested a review November 21, 2020 08:46
michaelstaib
michaelstaib previously approved these changes Nov 21, 2020
View reviewed changes
@michaelstaib michaelstaib moved this from backlog to review in Backlog Nov 21, 2020
@michaelstaib michaelstaib added this to the HC-11.0.0 milestone Nov 21, 2020
@sonarcloud
Copy link

sonarcloud bot commented Nov 21, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 20 Code Smells

94.3% 94.3% Coverage
2.9% 2.9% Duplication

@michaelstaib michaelstaib merged commit bad500f into main Nov 21, 2020
@michaelstaib michaelstaib deleted the pse/filtering-fix-naming branch November 21, 2020 11:02
@PascalSenn PascalSenn moved this from review to Done in Backlog Nov 21, 2020
michaelstaib pushed a commit that referenced this pull request Nov 27, 2020
@PascalSenn @michaelstaib
Reworked Filter Naming Conventions (#2618)
db5452e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstaib michaelstaib michaelstaib approved these changes

Assignees

@PascalSenn PascalSenn

Labels
🎨 refactoring This issue is about doing refactoring work, like cleaning up the code making existing code better.
Projects
No open projects
Backlog
  
Done
Milestone
HC-11.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PascalSenn @michaelstaib