-
-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reworked Filter Naming Conventions #2618
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
PascalSenn
commented
Nov 20, 2020
- Cleaner names of filter types
- Align names of spatial filter types
- UseFiltering() uses convention type lookup
- FilterExtensions can override defaults
michaelstaib
previously approved these changes
Nov 21, 2020
michaelstaib
changed the title
feat: filtering naming
Reworked Filter Naming Conventions
Nov 21, 2020
michaelstaib
added
🌶 hot chocolate
🎨 refactoring
This issue is about doing refactoring work, like cleaning up the code making existing code better.
labels
Nov 21, 2020
michaelstaib
previously approved these changes
Nov 21, 2020
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
michaelstaib
approved these changes
Nov 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🎨 refactoring
This issue is about doing refactoring work, like cleaning up the code making existing code better.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.