Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDR 'prepares to do battle' message is shown incorrectly. #205

Closed
IcemarkUK opened this issue Oct 30, 2023 Discussed in #203 · 0 comments · Fixed by #209
Closed

DDR 'prepares to do battle' message is shown incorrectly. #205

IcemarkUK opened this issue Oct 30, 2023 Discussed in #203 · 0 comments · Fixed by #209
Labels
bug DDR Doomdark's Revenge TME

Comments

@IcemarkUK
Copy link
Member

Discussed in #203

Originally posted by FrozenEmpire October 29, 2023
One potential anomaly I've come across is that cf_preparesbattle gets reset unconditionally as part of StartDawn, but then also conditionally at the end of the Night processing as well; this makes me think that it perhaps shouldn't get reset as part of StartDawn ?

the message should be shown in CheckPlace screen whenever a lord is at a location with an enemy.

It needs to be set as part of CMD_Attack / _Approach, and be set/reset at the end of the characters battle turn if enemies still in location. Also reset after a standard move.

@IcemarkUK IcemarkUK added bug TME DDR Doomdark's Revenge labels Oct 30, 2023
@IcemarkUK IcemarkUK linked a pull request Nov 2, 2023 that will close this issue
IcemarkUK added a commit that referenced this issue Nov 2, 2023
…battle-message-is-shown-incorrectly

#205 DDR correct lords prepares for battle flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug DDR Doomdark's Revenge TME
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant