[hacktoberfest] feat: Implement mobile money payout api #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 7, 2022 16:32
uchibeke
requested changes
Oct 11, 2022
| momoCodes?.data?.map((momoCode) => ( | ||
| <option | ||
| key={`${momoCode.name}-${momoCode.code}`} | ||
| value={momoCode.code} |
There was a problem hiding this comment.
Users don't understand what the codes are. Could you use the name of the service instead?
| return | ||
| } | ||
|
|
||
| if (paymentData.phoneNumber.length === 0) { |
There was a problem hiding this comment.
consider validating the phone number using a regex
| className={`${error.length === 0 ? 'mt-8' : 'mt-2'} px-12 py-2 border shadow-sm text-white rounded-xl | ||
| font-semibold bg-purple-500 hover:border-purple-500 tracking-wider | ||
| hover:bg-purple-50 hover:text-purple-500 hover:scale-95 transition-all`}> | ||
| PAY NOW |
There was a problem hiding this comment.
Are they paying? Or Sending, Transferring, Gifting or something else?
There was a problem hiding this comment.
They are paying into a momo account.
|
Hi @uchibeke please let me know if there's anymore changes to be made. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the mobile money api from the issue #2 in a simple React app.
See README for more info