Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix duplicate function call of _kill() #47

Merged
merged 1 commit into from
Mar 13, 2019
Merged

fix duplicate function call of _kill() #47

merged 1 commit into from
Mar 13, 2019

Conversation

gary837837
Copy link
Contributor

@gary837837 gary837837 commented Mar 6, 2019

Environments

  • os: ubuntu 18.04
  • node: v10.14.1
  • mirakurun: 2.8.4

When the record process which tuner has the option "dvbDevicePath" was killed, the code

this._kill(false);

still be called if the code
this._process.once("exit", () => this._exited = true);

execute later than cat.close()

@kanreisa kanreisa merged commit ce42250 into Chinachu:master Mar 13, 2019
@gary837837 gary837837 deleted the fix/tuner-device-kill branch March 14, 2019 00:07
@gary837837 gary837837 restored the fix/tuner-device-kill branch March 14, 2019 00:07
@gary837837 gary837837 deleted the fix/tuner-device-kill branch March 14, 2019 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants