Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/email subscription bug fixing #7

Conversation

lakesol
Copy link

@lakesol lakesol commented Feb 17, 2022

Description

Upon testing I found a number issues with email subscriptions. This PR hopes to address the following issues;

Purpose

  • Bugfix - Portal legal basis was not serialised correctly in some frameworks resulting in portal basis not being set via the API
  • New feature - You can now apply legal basis to an individual subscription as well at the portal level. This is defined as optional parameters to avoid breaking changes.
  • Bugfix - Corrected spelling mistake in SubscribeTo method parameters
  • New feature - Return opt state, legal basis and legal basis explanation when getting email subscriptions for a contact
  • Bugfix - UnsubscribeFrom was not removing subscriptions and was passing unneeded data in serialised API request
  • New feature - SubscriptionLegalBasis and SubscriptionLegalBasisExplanation properties within SubscribeHubSpotModel have been marked as obsolete and new Portal* properties have been created to more closely match API specification and avoid confusion with subscription legal basis - This is a non breaking change.

@lakesol lakesol changed the base branch from master to 0.6.19 February 17, 2022 14:07
@cdmdotnet
Copy link
Collaborator

Can you update the obsolete attribute to say which property to use instead. No issues with the implementation, just add a message so users know what to use as a replacement.

@cdmdotnet cdmdotnet self-requested a review February 17, 2022 19:52
@cdmdotnet cdmdotnet added the bug Something isn't working label Feb 17, 2022
Copy link
Collaborator

@cdmdotnet cdmdotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See conversation train

@lakesol
Copy link
Author

lakesol commented Feb 18, 2022

Obsolete attribute updated

@cdmdotnet cdmdotnet merged commit 3d2a88a into Chinchilla-Software-Com:0.6.19 Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants