Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed model.insert to skip fields set as undefined #1 #2

Merged
merged 1 commit into from
Oct 27, 2016
Merged

Changed model.insert to skip fields set as undefined #1 #2

merged 1 commit into from
Oct 27, 2016

Conversation

miketownsend
Copy link
Contributor

Optional (potentially incomplete) solution to make insert queries skip fields which have been set as undefined.

Probably needs a test.

Awesome project by the way - just changed over from Sequelize. Much friendlier.

@coveralls
Copy link

coveralls commented Oct 25, 2016

Coverage Status

Coverage remained the same at 92.184% when pulling 4078c97 on miketownsend:master into d163008 on ChiperSoft:master.

@Twipped
Copy link
Owner

Twipped commented Oct 26, 2016

Awesome, thank you. I'll try to get this merged in the morning and get a test in place for it.

@Twipped Twipped merged commit 4078c97 into Twipped:master Oct 27, 2016
@Twipped
Copy link
Owner

Twipped commented Oct 27, 2016

Change merged and published as v0.1.3.

Now that I know there's actual people using this, I guess it's time to put together a 1.0 release.

@miketownsend
Copy link
Contributor Author

miketownsend commented Nov 6, 2016

Thanks - yeah a release sounds useful and a readme would definitely help too. I'll chuck a few issues / ideas up as I find them.

I'd be interested to know what you had in mind as a roadmap for future develoment.

@miketownsend
Copy link
Contributor Author

Closes #1

@Twipped
Copy link
Owner

Twipped commented Nov 7, 2016

There's now a 1.0 branch if you want to take a look at what's coming. The main thing holding it back is that I need time to write a proper readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants