Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ItemOverrideList models are not handled by CTM #89

Closed
yrsegal opened this issue Dec 24, 2018 · 0 comments
Closed

ItemOverrideList models are not handled by CTM #89

yrsegal opened this issue Dec 24, 2018 · 0 comments

Comments

@yrsegal
Copy link

@yrsegal yrsegal commented Dec 24, 2018

When applying a CTM texture (for example, a glowing string for a bow) to a model with overrides/predicates, the override list is completely ignored, only applying the base model.

Because all vanilla models resolve to known states (ItemOverrideLists load their targets like any other model) this is possible without having to handle arbitrary model behavior.

Example:

This override fails to work when the rod is being used. fishing_rod_overlay is emissive.

{
  "parent": "item/handheld_rod",
  "textures": {
    "layer0": "rpsideas:items/ebony_fishing_rod",
    "layer1": "rpsideas:items/fishing_rod_overlay"
  },
  "overrides": [
    {
      "predicate": {
        "cast": 1
      },
      "model": "rpsideas:item/ebony_rod_cast"
    }
  ]
}

This override succeeds, with no emissive textures involved.

{
  "parent": "item/handheld_rod",
  "textures": {
    "layer0": "rpsideas:items/psimetal_rod"
  },
  "overrides": [
    {
      "predicate": {
        "cast": 1
      },
      "model": "rpsideas:item/psimetal_rod_cast"
    }
  ]
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.