Skip to content

Commit

Permalink
Update pkg/javascript dist directories to use dist_web/ and dist_node…
Browse files Browse the repository at this point in the history
…js/, (gluesql#1326)

build files in dist/web and dist/nodejs directories are ignored on npm publish with unknown reason.
avoid this issue by changing the dist directories to dist_web/ and dist_nodejs/
  • Loading branch information
panarch committed Jul 22, 2023
1 parent 7d2eeb8 commit 6f848dc
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 10 deletions.
2 changes: 2 additions & 0 deletions pkg/javascript/.gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
dist_web/
dist_nodejs/
dist/
node_modules/
bin/
Expand Down
4 changes: 2 additions & 2 deletions pkg/javascript/DEVELOPMENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ opt-level = "s"
### Build
```
# browser module, webpack and rollup
wasm-pack build --target web --no-typescript --release --out-dir ./dist/web
wasm-pack build --target web --no-typescript --release --out-dir ./dist_web
# nodejs
wasm-pack build --target nodejs --no-typescript --release --out-dir ./dist/nodejs -- --no-default-features --features nodejs
wasm-pack build --target nodejs --no-typescript --release --out-dir ./dist_nodejs -- --no-default-features --features nodejs
```

### 🔬 Test in Headless Browsers with `wasm-pack test`
Expand Down
2 changes: 1 addition & 1 deletion pkg/javascript/gluesql.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import init, { Glue } from './dist/web/gluesql_js.js';
import init, { Glue } from './dist_web/gluesql_js.js';

let loaded = false;

Expand Down
2 changes: 1 addition & 1 deletion pkg/javascript/gluesql.node.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const { Glue } = require('./dist/nodejs/gluesql_js.js');
const { Glue } = require('./dist_nodejs/gluesql_js.js');

function gluesql() {
return new Glue();
Expand Down
4 changes: 2 additions & 2 deletions pkg/javascript/gluesql.rollup.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import init, { Glue } from './dist/web/gluesql_js.js';
import loadDB from './dist/web/gluesql_js_bg.wasm';
import init, { Glue } from './dist_web/gluesql_js.js';
import loadDB from './dist_web/gluesql_js_bg.wasm';

let loaded = false;

Expand Down
8 changes: 4 additions & 4 deletions pkg/javascript/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@
},
"homepage": "https://gluesql.org/docs",
"files": [
"dist/nodejs/gluesql_js.js",
"dist/nodejs/gluesql_js_bg.wasm",
"dist/web/gluesql_js.js",
"dist/web/gluesql_js_bg.wasm",
"dist_nodejs/gluesql_js.js",
"dist_nodejs/gluesql_js_bg.wasm",
"dist_web/gluesql_js.js",
"dist_web/gluesql_js_bg.wasm",
"gluesql.js",
"gluesql.node.js",
"gluesql.rollup.js",
Expand Down

0 comments on commit 6f848dc

Please sign in to comment.