Skip to content

Commit

Permalink
Remove unnecessary comments in evalaute/function.rs (gluesql#1431)
Browse files Browse the repository at this point in the history
  • Loading branch information
panarch committed Oct 15, 2023
1 parent e417a88 commit 8a3ba04
Showing 1 changed file with 0 additions and 15 deletions.
15 changes: 0 additions & 15 deletions core/src/executor/evaluate/function.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1016,13 +1016,6 @@ pub fn splice<'a>(
}
};

/*
let list_data = match Value::try_from(list_data)? {
Value::List(list) => Ok(list),
_ => Err(EvaluateError::ListTypeRequired),
}?;
*/

let begin_index = eval_to_int(&name, begin_index)?.max(0);
let begin_index = usize::try_from(begin_index)
.map_err(|_| EvaluateError::FunctionRequiresUSizeValue(name.clone()).into())
Expand All @@ -1032,14 +1025,6 @@ pub fn splice<'a>(
.map_err(|_| EvaluateError::FunctionRequiresUSizeValue(name.clone()).into())
.into_control_flow()?;

/*
let begin_index = usize::try_from(eval_to_int!(name, begin_index).max(0))
.map_err(|_| EvaluateError::FunctionRequiresUSizeValue(name.clone()))?;
let end_index = usize::try_from(eval_to_int!(name, end_index).min(list_data.len() as i64))
.map_err(|_| EvaluateError::FunctionRequiresUSizeValue(name))?;
*/

let (left, right) = {
let mut list_iter = list_data.into_iter();
let left: Vec<_> = list_iter.by_ref().take(begin_index).collect();
Expand Down

0 comments on commit 8a3ba04

Please sign in to comment.