Skip to content

Commit

Permalink
Upgrade to version 0.4.31 and adjust millisecond value in Timestamp c…
Browse files Browse the repository at this point in the history
…reation (gluesql#1427)

Cause:
After upgrading to version 0.4.31, it was observed that the `and_hms_milli_opt()` function considers values of 1000 milliseconds (equivalent to 1 second) as potentially invalid unless representing a leap second with `sec == 59`. For the date `1989-03-20`, 1000 milliseconds was not a valid input.

Resolution:
Fixed the millisecond value in the `NaiveDate::from_ymd_opt()` function by changing it from `1000` to `999`, adjusting to the maximum valid millisecond value of `999`.

Signed-off-by: zmrdltl <meenseek5929@naver.com>
  • Loading branch information
zmrdltl committed Oct 29, 2023
1 parent 1b37cdd commit 903ccb7
Show file tree
Hide file tree
Showing 3 changed files with 568 additions and 451 deletions.

0 comments on commit 903ccb7

Please sign in to comment.