Add default impl codes to StoreMut trait (gluesql#1435)

ChobobDev · Oct 29, 2023 · bc71fe9 · bc71fe9
1 parent e248963
commit bc71fe9
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 30 deletions.
diff --git a/core/src/mock.rs b/core/src/mock.rs
@@ -84,30 +84,6 @@ impl StoreMut for MockStorage {
         self.schema_map.insert(table_name, schema);
         Ok(())
     }
-
-    async fn delete_schema(&mut self, _table_name: &str) -> Result<()> {
-        let msg = "[MockStorage] delete_schema is not supported".to_owned();
-
-        Err(Error::StorageMsg(msg))
-    }
-
-    async fn append_data(&mut self, _table_name: &str, _rows: Vec<DataRow>) -> Result<()> {
-        let msg = "[MockStorage] append_data is not supported".to_owned();
-
-        Err(Error::StorageMsg(msg))
-    }
-
-    async fn insert_data(&mut self, _table_name: &str, _rows: Vec<(Key, DataRow)>) -> Result<()> {
-        let msg = "[MockStorage] insert_data is not supported".to_owned();
-
-        Err(Error::StorageMsg(msg))
-    }
-
-    async fn delete_data(&mut self, _table_name: &str, _keys: Vec<Key>) -> Result<()> {
-        let msg = "[MockStorage] delete_data is not supported".to_owned();
-
-        Err(Error::StorageMsg(msg))
-    }
 }
 
 impl AlterTable for MockStorage {}

diff --git a/core/src/store/mod.rs b/core/src/store/mod.rs
@@ -29,7 +29,7 @@ pub use {
 use {
     crate::{
         data::{Key, Schema},
-        result::Result,
+        result::{Error, Result},
     },
     async_trait::async_trait,
     futures::stream::Stream,
@@ -54,13 +54,33 @@ pub trait Store {
 /// you can run `INSERT`, `CREATE TABLE`, `DELETE`, `UPDATE` and `DROP TABLE` queries.
 #[async_trait(?Send)]
 pub trait StoreMut {
-    async fn insert_schema(&mut self, schema: &Schema) -> Result<()>;
+    async fn insert_schema(&mut self, _schema: &Schema) -> Result<()> {
+        let msg = "[Storage] StoreMut::insert_schema is not supported".to_owned();
 
-    async fn delete_schema(&mut self, table_name: &str) -> Result<()>;
+        Err(Error::StorageMsg(msg))
+    }
 
-    async fn append_data(&mut self, table_name: &str, rows: Vec<DataRow>) -> Result<()>;
+    async fn delete_schema(&mut self, _table_name: &str) -> Result<()> {
+        let msg = "[Storage] StoreMut::delete_schema is not supported".to_owned();
 
-    async fn insert_data(&mut self, table_name: &str, rows: Vec<(Key, DataRow)>) -> Result<()>;
+        Err(Error::StorageMsg(msg))
+    }
 
-    async fn delete_data(&mut self, table_name: &str, keys: Vec<Key>) -> Result<()>;
+    async fn append_data(&mut self, _table_name: &str, _rows: Vec<DataRow>) -> Result<()> {
+        let msg = "[Storage] StoreMut::append_data is not supported".to_owned();
+
+        Err(Error::StorageMsg(msg))
+    }
+
+    async fn insert_data(&mut self, _table_name: &str, _rows: Vec<(Key, DataRow)>) -> Result<()> {
+        let msg = "[Storage] StoreMut::insert_data is not supported".to_owned();
+
+        Err(Error::StorageMsg(msg))
+    }
+
+    async fn delete_data(&mut self, _table_name: &str, _keys: Vec<Key>) -> Result<()> {
+        let msg = "[Storage] StoreMut::delete_data is not supported".to_owned();
+
+        Err(Error::StorageMsg(msg))
+    }
 }