This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
Upgrade to EasyRSA 3.x #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nikaro
commented
Sep 4, 2016
nikaro
commented
- Automatically grab the latest version of EasyRSA 3.x branch
- Adapt commands for CA and server certificates generation
- Rename vars from key_* to cert_* for those whose were not key related
- Keep default values if vars are empty
- Does not fail on empty MySQL root password, it is bad but it can happen
- Automatically grab the latest version of EasyRSA 3.x branch - Adapt commands for CA and server certificates generation - Rename vars from key_* to cert_* for those whose were not key related - Keep default values if vars are empty - Does not fail on empty MySQL root password, it is bad but it can happen
Test of port definition was reversed…
|
|
||
| if [[ "$server_port" == "443" || "$server_port" == "" ]]; then | ||
| if [[ -z $server_port ]]; then | ||
| server_port="443" |
There was a problem hiding this comment.
Oh yep, definitely better than my version 👍
|
Nice, I just have a little question (in code comment). Thanks @nikaro :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.