New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to EasyRSA 3.x #15

Merged
merged 2 commits into from Sep 5, 2016

Conversation

Projects
None yet
3 participants
@nikaro
Copy link
Contributor

nikaro commented Sep 4, 2016

  • Automatically grab the latest version of EasyRSA 3.x branch
  • Adapt commands for CA and server certificates generation
  • Rename vars from key_* to cert_* for those whose were not key related
  • Keep default values if vars are empty
  • Does not fail on empty MySQL root password, it is bad but it can happen
Upgrade to EasyRSA 3.x
- Automatically grab the latest version of EasyRSA 3.x branch
- Adapt commands for CA and server certificates generation
- Rename vars from key_* to cert_* for those whose were not key related
- Keep default values if vars are empty
- Does not fail on empty MySQL root password, it is bad but it can happen

@nikaro nikaro referenced this pull request Sep 4, 2016

Closed

EasyRSA 3.x + Refactoring #12

Fix test port number
Test of port definition was reversed…

if [[ "$server_port" == "443" || "$server_port" == "" ]]; then
if [[ -z $server_port ]]; then
server_port="443"

This comment has been minimized.

@SansPseudoFix

SansPseudoFix Sep 4, 2016

Collaborator

Oh yep, definitely better than my version 👍

while [ "$key_size" != "1024" -a "$key_size" != "2048" -a "$key_size" != "4096" ]; do
read -p "Key size (1024, 2048 or 4096): " key_size
done
read -p "Key size (1024, 2048 or 4096) [2048]: " key_size

This comment has been minimized.

@Chocobozzz

Chocobozzz Sep 5, 2016

Owner

Why did you remove the loop that checked the validity of the keysize?

This comment has been minimized.

@nikaro

nikaro Sep 5, 2016

Contributor

Because with EasyRSA 3 there is a default value, which is 2048, and the loop doesn't allow to just keep it by pressing Enter.

@Chocobozzz

This comment has been minimized.

Copy link
Owner

Chocobozzz commented Sep 5, 2016

Nice, I just have a little question (in code comment). Thanks @nikaro :)

@Chocobozzz Chocobozzz merged commit 481e0f7 into Chocobozzz:dev Sep 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment