Skip to content

Commit

Permalink
Prevent sending log error to server on 404
Browse files Browse the repository at this point in the history
  • Loading branch information
Chocobozzz committed Dec 28, 2022
1 parent ded68a9 commit d522369
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
6 changes: 5 additions & 1 deletion client/src/app/core/rest/rest-extractor.service.ts
Expand Up @@ -87,7 +87,11 @@ export class RestExtractor {

if (err.status !== undefined) {
const errorMessage = this.buildServerErrorMessage(err)
logger.error(`Backend returned code ${err.status}, errorMessage is: ${errorMessage}`)

const message = `Backend returned code ${err.status}, errorMessage is: ${errorMessage}`

if (err.status === HttpStatusCode.NOT_FOUND_404) logger.clientError(message)
else logger.error(message)

return errorMessage
}
Expand Down
8 changes: 8 additions & 0 deletions client/src/root-helpers/logger.ts
Expand Up @@ -27,13 +27,21 @@ class Logger {
warn (message: LoggerMessage, meta?: LoggerMeta) {
this.runHooks('warn', message, meta)

this.clientWarn(message, meta)
}

clientWarn (message: LoggerMessage, meta?: LoggerMeta) {
if (meta) console.warn(message, meta)
else console.warn(message)
}

error (message: LoggerMessage, meta?: LoggerMeta) {
this.runHooks('error', message, meta)

this.clientError(message, meta)
}

clientError (message: LoggerMessage, meta?: LoggerMeta) {
if (meta) console.error(message, meta)
else console.error(message)
}
Expand Down

0 comments on commit d522369

Please sign in to comment.