Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features list shows transcoding 'on' while it is 'off' in config #1850

Closed
LiPeK opened this issue May 27, 2019 · 0 comments · Fixed by #1851
Closed

Features list shows transcoding 'on' while it is 'off' in config #1850

LiPeK opened this issue May 27, 2019 · 0 comments · Fixed by #1851
Labels
Type: Bug 🐛 Confirmed bug, at least replicated once by another contributor

Comments

@LiPeK
Copy link
Contributor

LiPeK commented May 27, 2019 •
edited

In the transcoding configuration section I have disabled all the available resolutions and the 'Transcoding enabled' checkbox.
Now the 'Features found on this instance' section on about page shows the 'Transcode your videos in multiple resolutions' as enabled.

It seems that the problem is located here:

PeerTube/server/controllers/api/config.ts

Line 54 in 46b2cec

.filter(key => CONFIG.TRANSCODING.ENABLED === CONFIG.TRANSCODING.RESOLUTIONS[key] === true)

The workaround:
Enable all resolutions and disable transcoding.
LiPeK added a commit to LiPeK/PeerTube that referenced this issue May 27, 2019
@LiPeK
Update config.ts
3e490b6 
This should fix Chocobozzz#1850
@LiPeK LiPeK mentioned this issue May 27, 2019
Merged
Chocobozzz pushed a commit that referenced this issue May 28, 2019
@LiPeK @Chocobozzz
Update config.ts
465679c 
This should fix #1850
@Chocobozzz Chocobozzz added the Type: Bug 🐛 Confirmed bug, at least replicated once by another contributor label May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug 🐛 Confirmed bug, at least replicated once by another contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update config.ts - issue 1850 LiPeK/PeerTube
2 participants
@LiPeK @Chocobozzz