Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input-password type #3375

Closed
madmath03 opened this issue Nov 27, 2020 · 1 comment · Fixed by #3377
Closed

Add input-password type #3375

madmath03 opened this issue Nov 27, 2020 · 1 comment · Fixed by #3377
Labels
Component: PeerTube Plugin 📦 Features that can be developed in a plugin, but require PeerTube plugin API development Type: Feature Request ✨

Comments

@madmath03
Copy link
Contributor

Describe the problem to be solved

A plugin like auth-ldap displays the password in clear text in the settings form.

I would like plugins with sensitive information to allow edition without displaying their content.

Describe the solution you would like:

Add a input-password that plugins can use to set sensitive information.

Describe alternatives you have considered

None that I can think of.

I think I can provide a PR for that with roughly this content:

 type: 'input' | 'input-checkbox' | 'input-password' | 'input-textarea' | 'markdown-text' | 'markdown-enhanced'
  <input *ngIf="setting.type === 'input'" type="text" [id]="setting.name" [formControlName]="setting.name" />

  <input *ngIf="setting.type === 'input-password'" type="password" [id]="setting.name" [formControlName]="setting.name" />

  <textarea *ngIf="setting.type === 'input-textarea'" type="text" [id]="setting.name" [formControlName]="setting.name"></textarea>

PS: I hope I'm not saying anything wrong that already exists 😅 (did not find anything in docs about it).

@rigelk
Copy link
Collaborator

rigelk commented Nov 27, 2020

You are welcome to submit a PR 🙂

madmath03 added a commit to Monogramm/PeerTube that referenced this issue Nov 27, 2020
@madmath03 madmath03 mentioned this issue Nov 27, 2020
5 tasks
@Chocobozzz Chocobozzz added Component: PeerTube Plugin 📦 Features that can be developed in a plugin, but require PeerTube plugin API development Type: Feature Request ✨ labels Nov 30, 2020
Chocobozzz pushed a commit that referenced this issue Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PeerTube Plugin 📦 Features that can be developed in a plugin, but require PeerTube plugin API development Type: Feature Request ✨
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants