Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curl package to Dockerfile.buster to allow for healthchecks (swarm, k8s, etc.) #4045

Closed
decentral1se opened this issue May 6, 2021 · 1 comment · Fixed by #4046
Closed
Labels
Component: Docker 🐳 Deals with containerisation, a hellish nightmare for Chocobos Type: Feature Request ✨

Comments

@decentral1se
Copy link
Contributor

decentral1se commented May 6, 2021

Describe the problem to be solved

With docker swarm configs, you typically see a thing like this:

    healthcheck:
      test: ["cmd", "curl", "-f", "http://localhost:9000"]
      interval: 30s
      timeout: 10s
      retries: 10
      start_period: 10s

This allows swarm to understand when containers are healthy and do zero downtime deploys.

Curl appears to be missing from the default image published.

Describe the solution you would like:

Let's install curl in the default docker images.

Describe alternatives you have considered

Wget isn't there either, so it seems we're missing that approach.

@decentral1se
Copy link
Contributor Author

➜  peertube (main) ✗ docker run chocobozzz/peertube:v3.1.0-buster which curl 
➜  peertube (main) ✗ docker run chocobozzz/peertube:v3.1.0-buster which wget

@decentral1se decentral1se changed the title Add curl package to Dockerfile.buster to allow for healthchecks (swarm, k8s, etc.) Add curl package to Dockerfiles to allow for healthchecks (swarm, k8s, etc.) May 6, 2021
decentral1se pushed a commit to decentral1se/PeerTube that referenced this issue May 6, 2021
@decentral1se decentral1se changed the title Add curl package to Dockerfiles to allow for healthchecks (swarm, k8s, etc.) Add curl package to Dockerfile.buster to allow for healthchecks (swarm, k8s, etc.) May 6, 2021
@Chocobozzz Chocobozzz added Component: Docker 🐳 Deals with containerisation, a hellish nightmare for Chocobos Type: Feature Request ✨ labels May 7, 2021
Chocobozzz pushed a commit that referenced this issue May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Docker 🐳 Deals with containerisation, a hellish nightmare for Chocobos Type: Feature Request ✨
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants