Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database Name Environment #5708

Closed
berksmbl opened this issue Mar 24, 2023 · 8 comments · Fixed by #5734
Closed

Database Name Environment #5708

berksmbl opened this issue Mar 24, 2023 · 8 comments · Fixed by #5734
Labels
Component: Docker 🐳 Deals with containerisation, a hellish nightmare for Chocobos good first issue Type: Feature Request ✨

Comments

@berksmbl
Copy link

Describe the problem

By default the database name is "peertube" and it is not possible to change it with env variables, I can use the docker image only if I create a database as "peertube". However, I host my database as a service elsewhere, and the service provider does not give complete freedom to specify the database name.

Additional information

  • PeerTube version: production-bullseye (Docker)
  • Redis version: 7
  • PostgreSQL version: 14
@Chocobozzz Chocobozzz added Type: Feature Request ✨ Component: Docker 🐳 Deals with containerisation, a hellish nightmare for Chocobos good first issue labels Mar 31, 2023
@Jolg42
Copy link
Contributor

Jolg42 commented Apr 4, 2023

@berksmbl
Copy link
Author

berksmbl commented Apr 4, 2023

It looks to me that you could set the database name with POSTGRES_DB=mydbname from: https://github.com/Chocobozzz/PeerTube/blob/develop/support/docker/production/.env#L5

Hello, This variable only interacts with PostgreSQL. It has no interaction with PeerTube and continues to use its default value.

Jolg42 added a commit to Jolg42/PeerTube that referenced this issue Apr 5, 2023
@Jolg42
Copy link
Contributor

Jolg42 commented Apr 5, 2023

@berksmbl Indeed!
I opened a PR to make the appropriate change here: #5734

Chocobozzz pushed a commit that referenced this issue Apr 7, 2023
* feat(docker): make database name configurable

WIP
Related #5708

* Update .env

* PEERTUBE_DB_NAME & add comments
@berksmbl
Copy link
Author

@Chocobozzz The update still hasn't been released on Docker for production.

@Chocobozzz
Copy link
Owner

It's released on docker in develop-bullseye image

@berksmbl
Copy link
Author

berksmbl commented Apr 14, 2023

It's released on docker in develop-bullseye image

Hello @Chocobozzz, I am preparing an installation scheme through the one-click install logic on EasyPanel for people to use. We only create templates for production and stable versions. Unfortunately, I cannot use latest or develop versions here. Can you give me an ETC?

@Chocobozzz
Copy link
Owner

It will be in docker production image for the next release, ~2 months I think.

@berksmbl
Copy link
Author

It will be in docker production image for the next release, ~2 months I think.

Hello @Chocobozzz,
It's longer than I expected. What is the chance of releasing an interim update that only includes this small correction :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Docker 🐳 Deals with containerisation, a hellish nightmare for Chocobos good first issue Type: Feature Request ✨
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants