Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly don't cache HTML files #6393

Closed
kontrollanten opened this issue May 11, 2024 · 0 comments · Fixed by #6394
Closed

Explicitly don't cache HTML files #6393

kontrollanten opened this issue May 11, 2024 · 0 comments · Fixed by #6394

Comments

@kontrollanten
Copy link
Contributor

kontrollanten commented May 11, 2024

Describe the current behavior

Currently there's no Cache-Control header in HTML responses. This is causing a heuristic caching. As I understand it most browsers won't cache it since there's no Last-Modified header. But proxies and CDN's may behave different.

Steps to reproduce

Describe the expected behavior

Return Cache-Control: max-age=0, no-cache, must-revalidate for HTML pages.

Additional information

  • PeerTube instance:

    • URL: 6.1.0
    • Version:
    • NodeJS version:
    • Ffmpeg version:
  • Browser name, version and platforms on which you could reproduce the bug:

  • Link to browser console log if relevant:

  • Link to server log if relevant (journalctl or /var/www/peertube/storage/logs/):

kontrollanten added a commit to kontrollanten/PeerTube that referenced this issue May 12, 2024
Tell the clients to not cache the HTML response.

closes Chocobozzz#6393
Chocobozzz pushed a commit that referenced this issue May 13, 2024
Tell the clients to not cache the HTML response.

closes #6393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant