WIP: Fix #498

[Jorropo]

Fix #498

I cant actualy make it works.
For an unknown reason <br /> got been escaped while the same code doesn't do this in :

client/src/app/videos/+video-watch/video-watch.component.ts

It seems to be done by avoidTruncatedTags in :

client/src/app/shared/renderer/markdown.service.ts

but again in :

client/src/app/videos/+video-watch/video-watch.component.ts

this doesn't happend and I cant get why.

[Chocobozzz]

Because in video watch we inject the HTML:

<div class="video-info-description-html" [innerHTML]="videoHTMLDescription"></div>

If you add basic markdown in comments, please add a preview bloc when writing the comment.

[Jorropo]

@Chocobozzz this is the same things here :

<div class="comment-html" [innerHTML]="sanitizedCommentHTML"></div>

And the problem is <br /> transform to <br /> after been returned from await this.markdownService.textMarkdownToHTML(this.comment.text).
I've thinked to first make the text in await this.htmlRenderer.toSafeHtml(this.comment.text) but nothing change (logical because that not linked).

If you add basic markdown in comments, please add a preview bloc when writing the comment.

Yes, that a good idea, I didn't even think of that. Would you the preview in the bottom of the writing box (the preview box should open only when you are writing), asside of the write box (not disponible for mobile), or in a preview tab (like github does) ? (I think first one is the best)

[Chocobozzz]

And the problem is
transform to <br /> after been returned from await this.markdownService.textMarkdownToHTML(this.comment.text).
I've thinked to first make the text in await this.htmlRenderer.toSafeHtml(this.comment.text) but nothing change (logical because that not linked).

Ah yes sorry. Try to create another markdown renderer that accepts html (because we already sanitized it): https://github.com/markdown-it/markdown-it#init-with-presets-and-options

Yes, that a good idea, I didn't even think of that. Would you the preview in the bottom of the writing box (the preview box should open only when you are writing), asside of the write box (not disponible for mobile), or in a preview tab (like github does) ? (I think first one is the best)

I have no preference :)

[rigelk]

@Jorropo do you plan on finishing this PR, or do you need help with it?

[Chocobozzz]

Implemented in 1aa7543