Pre-build PeerTube again in dev Dockerfile. #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeerTube pre-build was removed in Chocobozzz#207 but is still valuable.
|
Additionally, building PeerTube within the dev Dockerfile has the merit of failing the Docker automated build if the PeerTube build contains errors. This prevents accidentally shipping dev images with a dysfunctional PeerTube build. |
|
From the #peertube IRC channel on Freenode:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PeerTube pre-build was removed in #207 because
npm run devalready builds it on-the-fly (see this comment).However, I find that
npm run devtakes too long to produce an initial build, causing errors when you try to use PeerTube right after startingnpm run dev.I feel like including a pre-built PeerTube in dev images is valuable and convenient. @Chocobozzz please have a look when you have time.