Expose PeerTube socket to plugins

[kontrollanten]

Description

Expose socket to plugins, so that they can send notifications and update live video state.

Related issues

#3282

Has this been tested?

Doesn't make sense to test this.

[Chocobozzz]

Thanks, but please design a public API so renaming an internal method don't impact plugins. Please also add server tests to ensure it correctly works.

[kontrollanten]

Great input. I created two basic tests to just ensure the API is callable. To really ensure it works I guess we'd need to setup a WS client and check the message received. I couldn't find more ways in testing it. Any input?

[kontrollanten]

@Chocobozzz The tests are failing at

Test live
       Live transcoding
         Should enable transcoding with some resolutions and correctly save them:
     AssertionError: expected 27 to be close to 30 +/- 2

I can't see that my changes affect this test, may it be flaky?

[Chocobozzz]

I can't see that my changes affect this test, may it be flaky?

I'll relax them!

[Chocobozzz]

To really ensure it works I guess we'd need to setup a WS client and check the message received. I couldn't find more ways in testing it. Any input?

Yes, you can take inspiration of https://github.com/Chocobozzz/PeerTube/blob/develop/server/tests/api/live/live-socket-messages.ts#L72