feat(plugins): add p2p-media-loader options filter #5318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chocobozzz
reviewed
Oct 10, 2022
| @@ -81,7 +81,7 @@ export class PeertubePlayerManager { | |||
|
|
|||
| const videojsOptions = await this.pluginsManager.runHook( | |||
| 'filter:internal.player.videojs.options.result', | |||
| videojsOptionsBuilder.getVideojsOptions(this.alreadyPlayed) | |||
| await videojsOptionsBuilder.getVideojsOptions(this.alreadyPlayed) | |||
There was a problem hiding this comment.
I don't think you need the await since the runHook function will automatically handle the result appropriately if it's a promise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add filter for p2p-media-loader-options filter
Related issues
closes #5317
Has this been tested?