Add helpers in the video watch view explaining how to comment/subscribe #533
Conversation
|
I think referencing the issue is too technicals for lambda users |
| @@ -19,6 +19,11 @@ | |||
| font-size: 13px; | |||
| } | |||
|
|
|||
| .comment-help { | |||
| display: inline-block; | |||
| margin-left: -50px; | |||
There was a problem hiding this comment.
I don't really like setting negative margins. Could you try to put the help icon in the title-page block to avoid that?
|
I agree link to issues in general can be daunting, but that's also reassuring: it tells the user we are tackling the issue. Especially in this case where users don't understand why a basic feature is so difficult to access. |
rigelk
force-pushed
the
helpers-subs-comment
branch
2 times, most recently
from
ab06c1b
to
e371d91
Compare
| @@ -21,6 +21,9 @@ | |||
| {{ video.channel.displayName }} | |||
| </a> | |||
| <!-- Here will be the subscribe button --> | |||
| <div class="video-info-help"> | |||
There was a problem hiding this comment.
I don't think you need this wrapper.
| Comments | ||
| </div> | ||
| <ng-template [ngIf]="video.commentsEnabled === true"> | ||
| <div class="comment-help"> |
There was a problem hiding this comment.
I don't think you need this wrapper.
| </div> | ||
| <ng-template [ngIf]="video.commentsEnabled === true"> | ||
| <div class="comment-help"> | ||
| <my-help helpType="custom" customHtml="You can either comment on the page of your instance where this video is federated with your PeerTube account, or via any ActivityPub-capable fediverse instance. For instance with Mastodon or Pleroma you can type in the search box <strong>@{{video.account.displayName}}@{{video.account.host}}</strong> and find back the video. Direct commenting capabilities are being worked on in <a href='https://github.com/Chocobozzz/PeerTube/issues/224'>#224</a>."></my-help> |
There was a problem hiding this comment.
<my-help *ngIf="video.commentsEnabled === true"...
| </div> | ||
|
|
||
| <ng-template [ngIf]="video.commentsEnabled === true"> | ||
| <ng-template [ngIf]="video.commentsEnabled === true"> |
| @@ -19,6 +19,16 @@ | |||
| font-size: 13px; | |||
| } | |||
|
|
|||
| .title-block { | |||
rigelk
force-pushed
the
helpers-subs-comment
branch
from
e371d91
to
a74af87
Compare
|
I like the idea but I think the text is too long. Maybe the button can link to a dedicated help page. |
| @@ -19,6 +19,14 @@ | |||
| font-size: 13px; | |||
| } | |||
|
|
|||
| .title-block .title-page { | |||
| margin-right: 0px; | |||
There was a problem hiding this comment.
wrong indentation + margin-right: 0
|
@tcitworld that's clearly a temporary band-aid solution, so I'm not sratching my head too much with the text. Where would you see the page? |
rigelk
force-pushed
the
helpers-subs-comment
branch
from
a74af87
to
8482f54
Compare
rigelk
force-pushed
the
helpers-subs-comment
branch
from
8482f54
to
f2c7e6d
Compare
|
Thanks @rigelk, nice job! I merge but if you think it's better ton put it in another page, feel free to open another PR! |
Account helper:
Comment helper: