Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS uses too much nesting sometimes #58

Closed
rstacruz opened this issue Oct 18, 2016 · 4 comments
Closed

CSS uses too much nesting sometimes #58

rstacruz opened this issue Oct 18, 2016 · 4 comments
Labels
accepting PRs enhancement Pull request that improves existing functionality

Comments

@rstacruz
Copy link
Contributor

For instance:

.choices__group .choices__heading {

...when you can just use .choices__heading. I typically restyle Choices.js to fit the project I'm working on, and using less-specific CSS selectors would help a lot.

@rstacruz
Copy link
Contributor Author

This is particularly problematic as well:

.choices__list--dropdown .choices__item--selectable {

Would that be alright to be expressed as just .choices__item--selectable?

@jshjohnson
Copy link
Collaborator

Hey!

Would you mind submitting a pull request for this?

Thanks :)

@jshjohnson jshjohnson added enhancement Pull request that improves existing functionality accepting PRs labels Oct 18, 2016
@rstacruz
Copy link
Contributor Author

Sure, though I'm not too familiar with the css styling here though so I
don't know if I can cover all cases :)

On Tue, Oct 18, 2016, 10:42 PM Josh Johnson notifications@github.com
wrote:

Hey!

Would you mind submitting a pull request for this?

Thanks :)


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#58 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEikaXFJVULhQZESBQfmFEZFOFhyX1Wks5q1NrNgaJpZM4KZ39a
.

@jshjohnson
Copy link
Collaborator

As of version 2.3.0, choices__heading is no longer one level deep in the CSS. The dropdown example you sent is necessary unfortunately.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting PRs enhancement Pull request that improves existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants