Fix custom properties for browsers #1027
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We've ran into this as well. This used to work in 9.0.1 |
|
I believe this was resolved by #1001 and should be fixed in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom properties does not work correct for Chrome and Firefox Browsers. It returns 'undefined' and [object Object] from client side.
To reproduce it just add 'data-custom-properties' to your option and check it in Chrome or Firefox like that:
<option value="1" data-custom-properties='<span>Primary</span>'>1</option>This small change fixes custom properties fields for browsers. Without it only Safari supports custom properties.