fix setChoices flow #730
Merged
fix setChoices flow #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshjohnson
reviewed
Nov 1, 2019
| // get polyfill settings from top level config | ||
| // @ts-ignore | ||
| const { settings } = require('../../../.eslintrc.json'); | ||
|
|
||
| // Adding non-polyfilable Symbol-related functions as they are most probably | ||
| // behind the flag | ||
|
|
||
| settings.polyfills.push('Symbol.toStringTag', 'Symbol.for', 'Object.getOwnPropertySymbols', 'Object.getOwnPropertyDescriptors') | ||
| settings.polyfills.push( | ||
| 'Symbol.toStringTag', |
There was a problem hiding this comment.
Do we actually use Symbol anywhere? 🤔
There was a problem hiding this comment.
Sure. Your favorite Array.from is based on Symbol.Iterable 😉
There was a problem hiding this comment.
But those here are due to webpack
jshjohnson
approved these changes
Nov 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reimplements #721