Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactoring #735

Merged
merged 15 commits into from Nov 3, 2019
Merged

Code refactoring #735

merged 15 commits into from Nov 3, 2019

Conversation

jshjohnson
Copy link
Collaborator

@jshjohnson jshjohnson commented Nov 3, 2019

Description

  • Reduce complexity of _addPredefinedChoices
  • Add JSDoc comments to utils
  • Remove legacy placeholder attributes from demo page

Screenshots (if appropriate)

Types of changes

  • Chore (tooling change or documentation change)
  • Refactor (non-breaking change which maintains existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jshjohnson jshjohnson added the refactor Pull request that refactors existing functionality label Nov 3, 2019
@codecov
Copy link

codecov bot commented Nov 3, 2019

Codecov Report

Merging #735 into master will increase coverage by 0.07%.
The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #735      +/-   ##
==========================================
+ Coverage   66.46%   66.53%   +0.07%     
==========================================
  Files          22       22              
  Lines        1309     1306       -3     
==========================================
- Hits          870      869       -1     
+ Misses        439      437       -2
Impacted Files Coverage Δ
src/scripts/actions/groups.js 100% <ø> (ø) ⬆️
src/scripts/components/list.js 24.32% <ø> (ø) ⬆️
src/scripts/actions/items.js 100% <ø> (ø) ⬆️
src/scripts/actions/choices.js 100% <ø> (ø) ⬆️
src/scripts/store/store.js 92% <ø> (ø) ⬆️
src/scripts/actions/misc.js 100% <ø> (ø) ⬆️
src/scripts/components/container.js 100% <100%> (ø) ⬆️
src/scripts/components/input.js 100% <100%> (ø) ⬆️
src/scripts/lib/utils.js 75.75% <14.28%> (+1.51%) ⬆️
src/scripts/choices.js 54.22% <50%> (-0.16%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6882f3...1ede39f. Read the comment docs.

public/index.html Outdated Show resolved Hide resolved
public/index.html Outdated Show resolved Hide resolved
@jshjohnson jshjohnson merged commit ab22347 into master Nov 3, 2019
@jshjohnson jshjohnson deleted the code-refactoring branch November 3, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Pull request that refactors existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant