Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable test on Safari #737

Merged
merged 3 commits into from Nov 4, 2019
Merged

Enable test on Safari #737

merged 3 commits into from Nov 4, 2019

Conversation

tinovyatkin
Copy link
Contributor

Description

Adds missing test on Safari for our suite of visual tests.

Types of changes

  • Chore (tooling change or documentation change)
  • Refactor (non-breaking change which maintains existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@tinovyatkin
Copy link
Contributor Author

@jshjohnson Please review the new Safari snapshot (GitHub allows to see side-by-side, so, it's handy) - it has some visual changes regarding placeholders, not sure is as supposed to be.

@jshjohnson
Copy link
Collaborator

jshjohnson commented Nov 4, 2019

I think the comparison is fine but I have noticed since the 'ch' unit PR that placeholder widths are a lot wider than they need to be:

Screenshot 2019-11-04 at 09 32 03

@tinovyatkin
Copy link
Contributor Author

@jshjohnson Yeah, I know and wrote in original PR (including a link to Chris Mayer writing about it), that ch is the width of 0, so, on average it's about 20% wider than normal text. We can tune that in separate PR.
But here I've mostly referred these cases where placeholder disappears at all - I've seen your recent changes to placeholder handling and not sure whether such behavior is desired or it's a regression?

Screenshot 2019-11-04 at 08 14 45

Anyway, I think it's better to merge like this (as it reflects current master state), so then any new changes will come with adjusted snapshots and easier to understand.

@jshjohnson
Copy link
Collaborator

The placeholder change removed the ability to pass a placeholder via config so that's expected 👍

@jshjohnson jshjohnson merged commit 81c44ba into Choices-js:master Nov 4, 2019
@tinovyatkin tinovyatkin deleted the test-on-safari branch November 4, 2019 13:23
@jshjohnson jshjohnson added the chore Pull request that does not change core code label Nov 4, 2019
@jshjohnson
Copy link
Collaborator

Hey - i'm not sure if it's related to this PR but visual checks seem to behaving strangely in this PR: #739 which was opened after merging this one

@tinovyatkin
Copy link
Contributor Author

I'm not sure neither, changes here are pretty minimal. I would prefer to wait a day to see if that's a Github Actions problem...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull request that does not change core code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants