Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Cypress to 3.6 and use cache in Github Actions #748

Merged
merged 5 commits into from Nov 8, 2019
Merged

Upgrade Cypress to 3.6 and use cache in Github Actions #748

merged 5 commits into from Nov 8, 2019

Conversation

tinovyatkin
Copy link
Contributor

@tinovyatkin tinovyatkin commented Nov 8, 2019

This PR upgrades Cypress to the current version (3.6).
Using new caching functionality caches Cypress cache what resulting in running time of ~2 mins, instead of current >3 min.
It also tunes the action in general, fixing some small errors.
Also removing unneeded prefixes in package.json, superseding stale #622

@tinovyatkin tinovyatkin changed the title try to cache cypress cache Upgrade Cypress to 3.6 and use cache in Github Actions Nov 8, 2019
run: npx run-p --race start cypress:run
- name: run Cypress (with or without recording)
# if we have ran out of free Cypress recordings, run Cypress with recording switched off
run: npx run-p --race start cypress:ci || npx run-p --race start cypress:run
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever!

@jshjohnson jshjohnson merged commit 68322d9 into Choices-js:master Nov 8, 2019
@jshjohnson
Copy link
Collaborator

Thanks! :)

@tinovyatkin tinovyatkin deleted the cache-cypress branch November 8, 2019 13:57
@jshjohnson jshjohnson added the chore Pull request that does not change core code label Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull request that does not change core code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants