Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant event listener conditional #755

Merged
merged 3 commits into from Nov 13, 2019
Merged

Conversation

jshjohnson
Copy link
Collaborator

Description

Removes a conditional that prevented key press handlers triggering.

Screenshots (if appropriate)

Types of changes

  • Chore (tooling change or documentation change)
  • Refactor (non-breaking change which maintains existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jshjohnson jshjohnson added the bugfix Pull request that fixes an existing bug label Nov 13, 2019
@codecov
Copy link

codecov bot commented Nov 13, 2019

Codecov Report

Merging #755 into master will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #755      +/-   ##
==========================================
+ Coverage   66.56%   66.74%   +0.17%     
==========================================
  Files          22       22              
  Lines        1316     1314       -2     
==========================================
+ Hits          876      877       +1     
+ Misses        440      437       -3
Impacted Files Coverage Δ
src/scripts/choices.js 54.51% <ø> (+0.13%) ⬆️
src/scripts/templates.js 75.9% <0%> (+1.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84b952e...f211b61. Read the comment docs.

@cypress
Copy link

cypress bot commented Nov 13, 2019



Test summary

121 0 0 0


Run details

Project Choices
Status Passed
Commit f211b61
Started Nov 13, 2019 3:34 PM
Ended Nov 13, 2019 3:35 PM
Duration 01:23 💡
OS Linux Ubuntu Linux - 18.04
Browser Electron 73

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@jshjohnson jshjohnson merged commit 933ea60 into master Nov 13, 2019
@jshjohnson jshjohnson changed the title Remove redundant check Remove redundant event listener conditional Nov 13, 2019
@jshjohnson jshjohnson deleted the fix-event-handler-bug branch November 28, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant