Prevent browser autocomplete suggestions on Choices elements

[bobmaerten]

This is the problem:

Safari will display a contact autocomplete on every text input which name attribute contains "name" or does not have any name attribute.

Steps to reproduce:

Use defaut Choices.js (9.0.1) with macOS Safari

This is my solution:

Adding a fine tuned nameattribute to the input should prevent that.

Plus, input type="search" seems more suited to the field intent (https://developer.mozilla.org/fr/docs/Web/HTML/Element/Input/search).

In the mean time, I'm using the same kind of solution explained in #598 (comment), mimic-ing the attribute addition in this PR as a JS callback on page loaded:

   const els = document.querySelectorAll('.choices__input--cloned');
    els.forEach((el, n) => {
      el.setAttribute("name", "search_terms")
      el.setAttribute("inputmode", "search")
    });

Types of changes

• Chore (tooling change or documentation change)
• Refactor (non-breaking change which maintains existing functionality)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[bobmaerten]

Holy cow, I wasn't prepared to all those failing tests! /o
Could someone guide me towards passing tests according to the changes I made (I'm a ruby guy)

[Defcon0]

Big thanks to you for fixing this!

[mtriff]

This seems good. Those test failures likely weren't anything to do with your change. Can you rebase on the latest version of master? I expect it will run cleanly and we can merge this.

[bobmaerten]

I can't easily rebase this patch as I made it from the GitHub editor. All I can do is close this PR and make another one after I cloned the repo on my account.

[mtriff]

Sounds good, that works too!

[bobmaerten]

I did manage to set up a remote branch on my setup and rebase the commit onto master.

[mtriff]

Great! Just the one failing test now (much better 😁). Can you update the test at src/scripts/templates.test.ts:507?

[mtriff]

Parfait, merci!