You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved the Issue [#27]
Making cell identifiers a static variable of the class is not an appropriate approach. Identifiers are written inside the constants to be used in multiple classes.
Hello! Thanks for contributing this project despite of no contribution guide. 😀
First, I'm using main branch for released code so please make PR for Develop branch
Second, I'm not understanding enough why using cell identifiers declared as static can you elaborate about this?
Sure @ChoiysApple I'll update the branch from develop and resolve the conflicts.
For the cell identifiers we don't have to make it static we can also use constant as well. The only issue is that we don't have to move cell identifiers inside each class because they are being used in multiple classes.
@AakifNadeem
Thanks for the elaboration. I'll proceed merging when conflicts are resolved.
But I was planning to do more(such as using RGB or Hex color for extension and using generics for cell identifiers) so I'll keep issue open.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved the Issue [#27]
Making cell identifiers a static variable of the class is not an appropriate approach. Identifiers are written inside the constants to be used in multiple classes.