This repository has been archived by the owner on Jan 5, 2024. It is now read-only.
[Fix] #58 ChartView category change is not working correctly #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- yml file not edited yet - lint error is not fixed yet
- disable line length rule - disable force try rule, But this rule must be enabled when issue #43 completed
<!--- Pull Request title must contains Category, issue number, issue description (e.g. "[Feature] #123 Adding new Gestures") --> ### Describe - Added [SwiftLint](https://github.com/realm/SwiftLint) for better code style ### Changes Made - Add [SwiftLint](https://github.com/realm/SwiftLint) to pod - disable some rules & exclude Pod from lint script - Fix Errors & warnings that SwiftLint makes ### Issues Resolved - #51 ### Additional context `force_try` rule is now disabled. Need to be enabled again after fixing issue #43
- Remake folders as Application, Presentation, Domain, Resources - Extract use-case code from APIService.swift into MovieAPI.swift - Rename Extension.swift to StyleExtensions.swift (Need to rework in future) - Rename Constants.swift to Identifiers.swift (Need to remove after issue #42)
Because this app is not using any storyboard for UI, Main.storyboard can be deleted - Delete Main.storyboard - Add Root ViewController to window at SceneDelegate method - Delete UISceneStoryboardFile property from info.plist
### Describe Reorganize file structure using example of [Template iOS App using Clean Architecture and MVVM](https://github.com/kudoleh/iOS-Clean-Architecture-MVVM) ### Changes Made 1. Reorganize file structure - Remake folders as Application, Presentation, Domain, Resources - Extract use-case code from APIService.swift into MovieAPI.swift - Rename Extension.swift to StyleExtensions.swift (Need to rework in future) - Rename Constants.swift to Identifiers.swift (Need to remove after issue [#42](#42)) 2. Remove Main.storyboard - Delete Main.storyboard - Add Root ViewController to window at SceneDelegate method - Delete UISceneStoryboardFile property from info.plist ### Issues Resolved - #33 ### Additional context `Constants.swift` renamed to `Identifiers.swift` but need to **remove** after issue [#42](#42)) close #33
- Create protocol to Presentation > Common
…sing ReusableCell's reuseIdentifer property automatically
This file is created to manage cell identifiers No need now
<!--- Pull Request title must contains Category, issue number, issue description (e.g. "[Feature] #123 Adding new Gestures") --> ### Describe `UITableView` `UICollectionView` reuse identifier refactoring ### Changes Made - Delete `Identifiers.swift` - Create `ReusableCell` Protocol and Extensions for `UITableView` and `UICollectionView` - Replace cell registration and reusing ### Issues Resolved - #42 ### Additional context About cells in `CreditViewController` - UITableView is using 2 UITableViewCell: (default `UITableViewCell` and `CreditTableViewDescriptionCell`) - Needed to create `CreditTableViewCell` to replace default `UITableView` - `CreditTableViewDescriptionCell` is not registered or reused, so there was some refactoring ### References [iOS Cell Registration and Reusing with Swift Protocol Extensions and Generics](https://medium.com/@gonzalezreal/ios-cell-registration-reusing-with-swift-protocol-extensions-and-generics-c5ac4fb5b75e) [Nicer reuse identifiers with protocols in Swift](https://medium.com/bleeding-edge/nicer-reuse-identifiers-with-protocols-in-swift-97d18de1b2df)
- Move view setting code from awakeFromNib() to custom initializer - Create setData and setUpLayout method for better code quality
### Describe `CreditTableViewCell` backgroundColor & textColor changing code is not working ### Changes Made - Move view setting code from awakeFromNib() to custom initializer - Create setData and setUpLayout method for better code quality ### Screenshots **AS-IS** <img src="https://github.com/ChoiysApple/Filmboard/assets/43776784/2d659b22-1876-4549-bf17-09691a9b84dd" width="25%" alt="this was image"> **TO-BE** <img src="https://github.com/ChoiysApple/Filmboard/assets/43776784/120df159-c92e-4749-80e5-d81c21b9388d" width="25%" alt="this was image"> ### Issues Resolved - #57
remove invalid adding currentPage
|
Wrong merge target branch
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe
currentPageproperty is added by 1 whenever category changed, new list is considered as next listChanges Made
Remove currentPage adding code from
requestData(category: MovieListCategory)Issues Resolved