183 fullscreen support #184
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds noise. When this is eliminated, fullscreen toggling can go under a shortcut key and a config parameter.
TheRealLaxity
approved these changes
Apr 6, 2024
The noise looked like it changed on every frame (very quickly anyway). You can have a look if you take out the clearing step. |
|
Mouse is not working properly at all in fullscreen :) |
Fixed, but solution needs an SDL2 upgrade |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for fixing #183
Hardcoded fullscreen
An extra clearing of the screen is done in
viewport:End()to eliminate noise in the 'letterboxed' areas. This seems like a hack; I would like to understand why crap is rendered there in the first place.TODO: