Fries for crobs #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preliminary work for adding post reactions
Chris-Johnston
requested changes
Apr 22, 2019
it worked as is, but this is better. Co-Authored-By: etcadinfinitum <lizzy.presland@gmail.com>
Crobs judge unnecessary standard output in _enterprise_ code Co-Authored-By: etcadinfinitum <lizzy.presland@gmail.com>
DURRRRRRRR Co-Authored-By: etcadinfinitum <lizzy.presland@gmail.com>
Added better stylings for the fries segment of the post Also added the unicode 馃崯 icon for REDUNDANCY
|
@Chris-Johnston let me know what you think about the naming conventions - I'm okay changing them if you really think we should, but I'm not inclined to make a keyword into a variable just in case something breaks down the line. Regarding the page reload - I'm still not sure how to go about implementing this, but would be okay making this into its own feature branch & PR due to addition of JS. In the interim, check out the majesty that is the new reaction section: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add reaction functionality for posts.
Could use a few more changes: