Update Navigation of Homepage #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update navbar behavior to stick to top
etcadinfinitum
approved these changes
Apr 23, 2019
| @@ -6,8 +6,9 @@ | |||
| <link rel="stylesheet" href="/static/style.css"> | |||
| </head> | |||
| <body> | |||
| <nav class="navbar navbar-dark bg-dark"> | |||
| <a class="navbar-brand" href="#">CROBBER</a> | |||
| <nav class="navbar sticky-top navbar-dark bg-dark"> | |||
There was a problem hiding this comment.
idk where this link text styling is coming from, but the CROBBER text is very dark against the dark themed navbar. would be nice to have this be more legible/less puzzling to look at
There was a problem hiding this comment.
jk, i fixed this in 62b7943 and added a href attribute to the navbar element that directs to the app's '/' route so now it has link highlighting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a couple small tweaks to the homepage template.