link against required libraries for klu feature
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Chris00. As an alternative to this PR, I've recently written a suitesparse_sys crate (https://crates.io/crates/suitesparse_sys) which handles everything, so sundials-sys could depend on this instead if that sounds better? |
Chris00
reviewed
Jul 1, 2024
Cargo.toml
Outdated
| nvecopenmp = [] | ||
| nvecpthreads = [] | ||
|
|
||
| [dependencies] | ||
| suitesparse_sys = { git = "https://github.com/martinjrobins/suitesparse-sys", optional = true, features = ["build_vendor"] } |
There was a problem hiding this comment.
This cannot be merged for two reasons:
- crate.io does not allow packages to be published with dependencies on code published outside of crates.io itself;
build_vendorshould not be imposed on the user — if the library is present on his system, he may want to use that version.
There was a problem hiding this comment.
I've published this crate now and removed build_vendor so it'll use the system suitesparse if possible
…parse_sys will take care of klu lib)
|
Thanks for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SunLinSolKLU solver in sundials requires the following libraries:
sundials_sunlinsolklufrom sundialsklu,suitesparseconfig,colamd,klu,btf, andamdfrom suitesparseThis adds these libraries to
rustc-link-lib, and adds the suitesparse lib dir to the link search path