Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Minifier doesn't work with non-latin path #90

Closed
Ilya-Zhulin opened this issue Sep 27, 2021 · 9 comments
Closed

[BUG] Minifier doesn't work with non-latin path #90

Ilya-Zhulin opened this issue Sep 27, 2021 · 9 comments

Comments

@Ilya-Zhulin
Copy link

Ilya-Zhulin commented Sep 27, 2021

Search first
Please make sure, that your issue is not covered by any other ticket. Please search first before you create a ticket.

  • Yes, I'm sure.

Describe the bug
Error of minification if project path contains non latin simpbols - russian in my case (Документы).

To Reproduce
Steps to reproduce the behavior:

  1. Go to on your PC
  2. Click on NetBeans icon
  3. Start new project
  4. Create new project in the path with non-latin folder name
  5. Create JavaScript file
  6. Fill it by some code
  7. Save this file
  8. Try to minify it.
  9. See error

Expected behavior
I expect, that plug-in works with all path and file will be minified. It works with Latin path.

Screenshots
image

Environment (please complete the following information):

  • OS: Windows 10 the last update
  • NetBeans version: 12.5
  • JDK version: 16

Additional context
Now I use Netbeans 12.5 and minifier 3.4. You can copy this word Документы to call your folder to replay the problem. This word means Documents.

@Chris2011
Copy link
Owner

Chris2011 commented Sep 27, 2021

Hey @Ilya-Zhulin sry but I did create the issue template w/ good reason. So why didn't you follow the template? Next time I will close the ticket immediately. So as I need to GUESS, you minified one file, right?

Please next time, read the template, go step by step and add every little information that needs to identiy the bug. Thx.

@Chris2011
Copy link
Owner

Also a title is missing.

@Ilya-Zhulin Ilya-Zhulin changed the title [BUG] [BUG] Minifier doesn't work with non-latin path Sep 27, 2021
@Ilya-Zhulin
Copy link
Author

I described all needed info. I felt your template, now you have also info about my PC.

@Chris2011
Copy link
Owner

Will have a look soon. Thx for reporting :)

@Chris2011
Copy link
Owner

Unfortunately this bug is coming from the google closure compiler. Will check whether there is an update or an existing bug there. Or maybe there is a command line argument wrong from my side.

@Chris2011
Copy link
Owner

@Ilya-Zhulin please see the last comment: google/closure-compiler#3784 (comment)

@Chris2011
Copy link
Owner

So my workaround on this and also I guess it is not really common to use non latin characters for filenames (Just IMHO). For development we should already use latin stuff, so I would ask you whether you can rename just your files to latin names. I think/hope that the code inside the file should work.

@Ilya-Zhulin
Copy link
Author

Hey! Of course it is not common situation.. I just found it and report to dev. Thanks that you tried to solve it. It's not a big problem, I transferred my files time ago to latin path and now it works good. Thank you.

@Chris2011
Copy link
Owner

Great you for your understanding :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants