Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support patterns for Gitlab.com #20

Closed
Chris2011 opened this issue May 6, 2015 · 8 comments
Closed

Support patterns for Gitlab.com #20

Chris2011 opened this issue May 6, 2015 · 8 comments
Assignees
Milestone

Comments

@Chris2011
Copy link
Owner

In my daily work, I have to use gitlab, but when I want to use your tool, to open the external url, it doesn't work, because I don't get an entry. I think that the support for gitlab is missing.

Regards

Chris

@markiewb
Copy link
Collaborator

markiewb commented Sep 5, 2015

@Chris2011 : Do you know a public gitlab server where I can try it out?

@Chris2011
Copy link
Owner Author

unfortunately no but maybe you will find at google with this phrase a free one: site:git.. gitlab.

@markiewb
Copy link
Collaborator

markiewb commented Sep 8, 2015

https://gitlab.com/paulodiovani/ci-tests-nodejs looks promising.
@Chris2011: Do you use a private gitlab installation at your workplace or are patterns for gitlab.com enough?

@Chris2011
Copy link
Owner Author

In our company we have this url: https://git.company.net/ so we have a private gitlab repo in our company.

@markiewb markiewb changed the title Support patterns for Gitlab Support patterns for Gitlab.com Sep 17, 2015
@markiewb markiewb modified the milestones: 1.3.8, 1.4.0 Sep 17, 2015
@markiewb markiewb self-assigned this Sep 17, 2015
@markiewb
Copy link
Collaborator

@Chris2011: The pattern of your gitlab installation is too generic. I do not know, what is the distinguish part there. But I extracted the patterns into a "property file", which can be altered by you for your needs.

In the options panel (#27 )

  • duplicate the lines of gitlab (starting with gitblit.)
  • replace the gitblit identifier with a new identifier like gitlabAtWork
  • update the patterns to match your server url
  • add your new new identifier to $.global.strategies

@Chris2011
Copy link
Owner Author

Thx, I will test your plugin soon :) 👍

@Chris2011
Copy link
Owner Author

Added new pattern to gitlab, works as expected, thx :) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants