Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Change editor background color when LoC changes #65

Open
ChrisCarini opened this issue Jul 5, 2022 · 3 comments
Open

Comments

@ChrisCarini
Copy link
Owner

Feedback provided by @harrisjasmine (TL;DR'd):

The widget icon & text are nice, but they are very small and hard to notice while coding. It would be nice to have a more obvious visual indicator to the user that they are reaching the various 'LoC change points'.

@ChrisCarini
Copy link
Owner Author

Changing the background might be more difficult than expected; there appear to be 2 ways to change the background:

  1. Via a custom theme
  2. Via a background image

A custom theme

A custom theme seems to have only static color codes available to set, though perhaps a totally custom UI theme could be created w/ a method to determine the color - look into UITheme

A background image

A background image seems to be a bit easier, though still difficult. Maybe based on what Yann said in this JB platform thread and using a custom set of background images provided in the plugin resources dir. Eventually calling IdeBackgroundUtil.repaintAllWindows() like in BackgroundImageDialog.doOKAction() (set a breakpoint in doOKAction() on the repaintAllWindows(); call, and see the prop key and value being set.

ChrisCarini added a commit that referenced this issue Apr 12, 2023
Bumps [org.mockito:mockito-core](https://github.com/mockito/mockito) from 5.2.0 to 5.3.0.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](mockito/mockito@v5.2.0...v5.3.0)

---
updated-dependencies:
- dependency-name: org.mockito:mockito-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ChrisCarini added a commit that referenced this issue Apr 12, 2023
…) (#156)

Bumps [org.mockito:mockito-core](https://github.com/mockito/mockito) from 5.2.0 to 5.3.0.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](mockito/mockito@v5.2.0...v5.3.0)

---
updated-dependencies:
- dependency-name: org.mockito:mockito-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Repository owner deleted a comment from allcontributors bot Sep 21, 2023
@ChrisCarini
Copy link
Owner Author

@all-contributors please add @harrisjasmine for ideas, userTesting

@allcontributors
Copy link
Contributor

@ChrisCarini

I've put up a pull request to add @harrisjasmine! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant